Avoid raising StopIterator in generators #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [PEP-479](https://www.python.org/dev/peps/pep-0479/) StopIteration should not be used any more to indicate the termination of a generator. Starting from Python 3.7 this behaviour is always enforced and a RuntimeError is raised instead. We now return instead of raising StopIteration.
thedrow
force-pushed
the
thedrow-patch-1
branch
from
761269a
to
9ff8083
Compare
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 63 63
Lines 6529 6529
Branches 780 780
=======================================
Hits 5783 5783
Misses 663 663
Partials 83 83
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 63 63
Lines 6529 6529
Branches 780 780
=======================================
Hits 5783 5783
Misses 663 663
Partials 83 83
Continue to review full report at Codecov.
|
auvipy
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PEP-479 StopIteration should not be used any more to indicate the termination of a generator.
Starting from Python 3.7 this behaviour is always enforced and a RuntimeError is raised instead.
We now return instead of raising StopIteration.