Reintroduce ca_certs and ciphers parameters of SSLTransport._wrap_socket_sni() #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ket_sni() This fixes issue introduced in commit: 53d6777
|
I'll release this as soon as possible. |
|
@matusvalo LGTM, sorry to be late. Well done! |
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
Patch Set 2: It seems that pyamqp re-introduced the ca_certs parameter in [1] and released that fix in 5.0.2[2]. Still we need to wait for kombu to release a new version that requires pyamqp 5.0.2. Then I will updated this path to bump kombu and amqp package version upwards instead of pinning downwards. [1]celery/py-amqp#344 [2]https://github.com/celery/py-amqp/commits/v5.0.2 Patch-set: 2 Reviewer: Gerrit User 9708 <9708@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
Patch Set 2: > It seems that pyamqp re-introduced the ca_certs parameter in [1] > and released that fix in 5.0.2[2]. Still we need to wait for kombu > to release a new version that requires pyamqp 5.0.2. Then I will > updated this path to bump kombu and amqp package version upwards > instead of pinning downwards. > > > [1]celery/py-amqp#344 > [2]https://github.com/celery/py-amqp/commits/v5.0.2 Do we need to wait for a new kombu release? They have 5<=pyamqp<6, which should be fine. Patch-set: 2 Reviewer: Gerrit User 14826 <14826@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
Patch Set 3: > Patch Set 2: > > > It seems that pyamqp re-introduced the ca_certs parameter in [1] > > and released that fix in 5.0.2[2]. Still we need to wait for kombu > > to release a new version that requires pyamqp 5.0.2. Then I will > > updated this path to bump kombu and amqp package version upwards > > instead of pinning downwards. > > > > > > [1]celery/py-amqp#344 > > [2]https://github.com/celery/py-amqp/commits/v5.0.2 > > Do we need to wait for a new kombu release? They have 5<=pyamqp<6, which should be fine. OK, lets try this. See PS3 Patch-set: 3 Reviewer: Gerrit User 9708 <9708@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342 This fixes issue introduced in PR #327