Prevent a UTF-8 decoder error from breaking Celery #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL socket read timeouts are not raised as socket.timeout exceptions. So, to have SSL socket read timeouts behave the same way as TCP socket read timeouts, we need to find them based off of their text and reraise as socket.timeout exceptions. This is similar to the fix in read_timeout in connection.py at: https://github.com/celery/py-amqp/blob/1.4/amqp/connection.py#L336-L337 and in fact the exception raised here is eventually caught by read_timeout and replaced with a socket.timeout exception. The problem is that the transport is already marked as disconnected at that point. So, we need to catch the timeout here in transport.py
Don't disconnect transport on SSL read timeout
There is a bug in the python socket library wherein attempting ssl.read/write on a closed socket raises an AttributeError instead of IOError. We need to catch that case and raise an IOError.
Fixes issue celery#85: the module can be imported on python 2.7.3 running i…
|
I think this is caused by running an older Python 2.7 version, and it was also fixed in master just now! |
djsmith42
force-pushed
the
utf8-error-handling
branch
from
3bc856f
to
6acce57
Compare
|
I rebased the latest master (oops, should have merged), but I'm still getting test failures with a similar error. However, now at least half of the tests are passing. The other half'ish are failing like this: |
|
I am running Python 2.7.3 on Ubuntu 12.04 |
…rojects As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’: > Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard. Test Plan: Manually visited all the links I’ve modified.
Convert readthedocs link for their .org -> .io migration for hosted projects
|
I think this was fixed in #88 |
|
Not fixed all in #88, as too many pack/unpack in the source code... |
|
plz send a new clean pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a non-UTF8 encoded header string would cause an uncaught
UnicodeDecodeError, which would cause an unrecoverable Celery
error. Now we will log non-UTF8 header strings (names and values), ignore them, and
continue processing.
Closes https://github.com/celery/celery/issues/2873