Avoid non-determinstic default keyword argument appearing in documentation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation. Whilst working on the Reproducible Builds effort [0], we noticed that vine could not be built reproducibly. This is due to the use of a set datatype in the default keyword arguments - this causes a problem when generating the documentation as the ordering is non-determinstic. (Mutable datatypes as default keyword arguments are also frowned upon in Python) [0] https://reproducible-builds.org/ Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
|
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort [0], we noticed
that vine could not be built reproducibly. This is due to the use of a
set datatype in the default keyword arguments - this causes a problem
when generating the documentation as the ordering is non-determinstic.
(Mutable datatypes as default keyword arguments are also frowned upon in
Python)
[0] https://reproducible-builds.org/
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk