-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Admit new input: packageName #36
Conversation
…to publish the container
i've added a previous step for preparing the env vars and reusing them later, it's already tested and works: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and LFG
Apart from that - we can consider moving to this style in the future
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action
Co-authored-by: Nguyen Nhu Viet <braveryandglory@gmail.com>
Interesting one! 📝 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Overview
Hello team!
Some context here.
Sometimes is possible that we have multiples
Dockerfiles
in the same repo (monorepo approach for example), and we have the need to specify a different package in our registry, this feature allow us to specify via github inputs the registry name where we'll publish the container.ℹ️ Keeping by default, the one that we were using before, the repository name.
Checklist