Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Admit new input: packageName #36

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented Feb 21, 2023

Overview

Hello team!

Some context here.

Sometimes is possible that we have multiples Dockerfiles in the same repo (monorepo approach for example), and we have the need to specify a different package in our registry, this feature allow us to specify via github inputs the registry name where we'll publish the container.

ℹ️ Keeping by default, the one that we were using before, the repository name.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Already tested: here with this

@tty47 tty47 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 21, 2023
@tty47 tty47 self-assigned this Feb 21, 2023
@tty47 tty47 requested a review from a team as a code owner February 21, 2023 11:04
Bidon15
Bidon15 previously approved these changes Feb 21, 2023
@tty47 tty47 requested a review from smuu February 21, 2023 11:23
smuu
smuu previously approved these changes Feb 21, 2023
@tty47 tty47 dismissed stale reviews from smuu and Bidon15 via 21c6f26 February 21, 2023 12:06
@tty47 tty47 requested review from Bidon15 and smuu February 21, 2023 12:28
@tty47
Copy link
Contributor Author

tty47 commented Feb 21, 2023

hello @Bidon15 @smuu

i've added a previous step for preparing the env vars and reusing them later, it's already tested and works:
example here

Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and LFG

Apart from that - we can consider moving to this style in the future
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

tty47 and others added 2 commits February 21, 2023 13:58
@tty47
Copy link
Contributor Author

tty47 commented Feb 21, 2023

One nit and LFG

Apart from that - we can consider moving to this style in the future https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

Interesting one! 📝
as this pipeline starts growing, maybe this could be the next(future) iteration

@Bidon15
Copy link
Member

Bidon15 commented Feb 21, 2023

One nit and LFG
Apart from that - we can consider moving to this style in the future https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

Interesting one! 📝 as this pipeline starts growing, maybe this could be the next(future) iteration

#37

Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tty47 tty47 merged commit d86d097 into main Feb 21, 2023
@tty47 tty47 deleted the jose/fix-image-names-multiple-dockerfiles branch February 21, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants