Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: remove buggy echo statement #78

Merged
merged 1 commit into from
Oct 12, 2023
Merged

bug: remove buggy echo statement #78

merged 1 commit into from
Oct 12, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 11, 2023 •
edited
Loading

Overview

Noticed a bug when upgrading node. Not sure why it didn't get flagged when I tested it.
There where unneeded echo statements that didn't have a closed parentheses.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from a team as a code owner October 11, 2023 20:10
@MSevey MSevey mentioned this pull request Oct 11, 2023
Merged
5 tasks
@MSevey MSevey mentioned this pull request Oct 12, 2023
Closed
5 tasks
tty47
tty47 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Bidon15 Bidon15 merged commit daf0ee3 into main Oct 12, 2023
8 checks passed
@Bidon15 Bidon15 deleted the sevey/echo-error branch October 12, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@Bidon15 Bidon15 Bidon15 approved these changes

@tty47 tty47 tty47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MSevey @ramin @Bidon15 @tty47