Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default indexer to null #1178

Closed
evan-forbes opened this issue Jan 5, 2023 · 6 comments
Closed

Set default indexer to null #1178

evan-forbes opened this issue Jan 5, 2023 · 6 comments
Assignees
@michiboo
Labels
good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member

Currently we have the tx indexer set to "kv" by default, when most full nodes do not need that functionality, so we should switch it to "null".
@evan-forbes evan-forbes added the good first issue Good for newcomers label Jan 5, 2023
@michiboo
Copy link
Contributor

michiboo commented Jan 9, 2023

Hello can I have a go at this issue?

@michiboo
Copy link
Contributor

@evan-forbes in which file can I find the tx indexer?

@rootulp
Copy link
Collaborator

rootulp commented Jan 10, 2023

Potentially relevant:

Given this issue was created in celestia-app, perhaps @evan-forbes would like celestia-app to override the default config in celestia-core so something like this here:

                         // other overrides ...
			tmCfg.Consensus.SkipTimeoutCommit = false
+			tmCfg.TxIndex.Indexer = "null"

Although we may also want to change the default config in celestia-core

michiboo added a commit to michiboo/celestia-app that referenced this issue Jan 11, 2023
@michiboo
celestiaorg#1178: Set default indexer to null
e175b42 
Signed-off-by: micky <chanmickyyun@gmail.com>
@michiboo michiboo mentioned this issue Jan 11, 2023
Merged
5 tasks
@michiboo
Copy link
Contributor

@evan-forbes @rootulp I opened a PR #1220 for this issue but now question is do I need to change it in celestia-core as well?

@cmwaters
Copy link
Contributor

@evan-forbes @rootulp I opened a PR #1220 for this issue but now question is do I need to change it in celestia-core as well?

I think the PR to celestia-app is sufficient.

cmwaters pushed a commit that referenced this issue Jan 12, 2023
@michiboo
#1178: Set default indexer to null (#1220)
9cbed53 
As per #1178, default indexer set to null from kv

Signed-off-by: micky <chanmickyyun@gmail.com>
@cmwaters
Copy link
Contributor

I believe we can close this as being completed

@rootulp rootulp mentioned this issue Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michiboo michiboo

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rootulp @michiboo @cmwaters @evan-forbes