Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add preview github action for specs #1495

Closed
rootulp opened this issue Mar 16, 2023 · 2 comments
Closed

ci: add preview github action for specs #1495

rootulp opened this issue Mar 16, 2023 · 2 comments
Assignees
Labels
specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Mar 16, 2023

We should add the preview github action we have on the docs https://github.com/celestiaorg/docs/blob/main/.github/workflows/preview.yml

This allows us to verify the deployed site on the pull request.

Fine for this to be a follow up.

Originally posted by @MSevey in #796 (comment)

@rootulp rootulp added the specs directly relevant to the specs label Mar 16, 2023
@rootulp rootulp added this to the Mainnet milestone Mar 16, 2023
This was referenced Mar 16, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 16, 2023

We added the workflow in #1497 but there is a permissions issue that prevents the action from commenting on the PR with a link to the deployed GH pages.

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 17, 2023

PR preview works on branches for this repo. See #1501 (comment). However, PR preview doesn't work for branches on forks.

This Action does not currently support deploying previews for PRs from forks, but will do so in the upcoming v2.

Ref: https://github.com/rossjrw/pr-preview-action so I'll create a separate issue to track upgrading the PR Preview action when v2 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs directly relevant to the specs
Projects
None yet
Development

No branches or pull requests

2 participants