Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The relayer sometimes relays weird signatures #374

Closed
Tracked by #301
rach-id opened this issue Apr 29, 2022 · 2 comments
Closed
Tracked by #301

The relayer sometimes relays weird signatures #374

rach-id opened this issue Apr 29, 2022 · 2 comments
Assignees

Comments

@rach-id
Copy link
Member

rach-id commented Apr 29, 2022

As stated in #372 (comment),
The relayer relayed for two times wrong signatures to the QGB contract.

The wrong byte code for the transaction:

0xe3e51e1900000000000000000000000000000000000000000000000000000000000000064be9e966d358bc5b4af5b71dd24145f0a3be9b5c2f3fcbfaff4597169b8919b2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000e00000000000000000000000000000000000000000000000000000000000000001000000000000000000000000966e6f22781ef6a6a82bbb4db3df8e225dfd948800000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000001b627828795a7ca2313c5dfa37fbc5636a3cd8be59d8e4c68d5319926307fcf33a2a3361bbc38d63ae38b2ac5e0aaf4e29b4da4d9d0b11479a246fb0b7d30fc9a1

Correct byte code for transaction:

0xe3e51e1900000000000000000000000000000000000000000000000000000000000000064be9e966d358bc5b4af5b71dd24145f0a3be9b5c2f3fcbfaff4597169b8919b2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000e00000000000000000000000000000000000000000000000000000000000000001000000000000000000000000966e6f22781ef6a6a82bbb4db3df8e225dfd948800000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000001ca7a5bfadc5c6f0ac813fd39abedc14a3b904db13e9d0ac508a8a4ef42e50b0a91e23ea74346cdbfafec619c71170b196f8a9fea93fb71e94e8c0ddf1e27ad79e

This needs to be investigated.

@rach-id
Copy link
Member Author

rach-id commented Apr 29, 2022

From a first look, it looks like it has to do with the mechanism we're using to relay.
I reckon this would be fixed with the new worker pool design.

@rach-id
Copy link
Member Author

rach-id commented Jun 23, 2022

The issue was when relaying signatures, they need to be ordered in the same order that valset members are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant