Relayer query right valset for confirmations #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x/qgb/types/query.pb.go
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
…nfirmations # Conflicts: # x/qgb/keeper/query_valset.go
|
Can be merged after #351 |
…nfirmations # Conflicts: # x/qgb/orchestrator/orchestrator.go # x/qgb/orchestrator/orchestrator_client.go # x/qgb/orchestrator/querier.go # x/qgb/orchestrator/relayer.go # x/qgb/orchestrator/relayer_client.go
rach-id
changed the title
|
Nevermind the ugly history, everything will be squashed. |
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
May 9, 2022
* adds valset request by nonce * add querier, broadcaster and updates orchestrator to use them * partially fix the tests for the new design * update the deployer for the new design * update orchestrator to new design * Adds querier and evm client update * update relayer to new design * fix query.proto * update deploy_command to use new Querier * formatting * formatting * go.sum * adds query last unbonding height * adds orchestrator valset replay * adds orchestrator data commitment replay * cosmetics * puts valset signature catchup in a separate function * puts data commitment signature catchup in a separate function * Querier cosmetics * go.sum * rename querier and catchup functions * adds genesis case to querylastvalset * format + todo * initialized tm logger in test * update orchestrator code to use uint64 instead of int64 * better logging * adds last valset request before height query * regenerating correct query.pb.go * adds logs * adds querier QueryLastValsetBeforeHeight and QueryDataCommitmentConfirmsByExactRange * fixes relayer to correctly send commitments * Update x/qgb/orchestrator/orchestrator_client.go Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> * formats import * rename addOldValsetAttestations and addOldDataCommitmentAttestations * defering logging instead of repeating it on every return * adds comment * nit * use the right function for data commitment to tm.hash * better logging * missing from merge * add comments Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries the right valsets/data commitment confirmations when relaying + final changes for a working QGB contract.
Closes #363
QGB contract in action: https://rinkeby.etherscan.io/address/0xEAcC249c0831f8DE0B6afe27e6179Ca29Dec9b74
Still investigating why it reverted at data commitment nonce 6...
Edit: for some reason, I restarted the relayer after an hour, and it just continued. Needs to be investigated. The only difference between the two byte codes is the signatures. So, probably we have an issue when querying for the signatures (issue tracking this #374)