Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ADR 10 Remove MsgWirePayForBlob #1005

Merged
merged 9 commits into from
Mar 28, 2023
Merged

docs: ADR 10 Remove MsgWirePayForBlob #1005

merged 9 commits into from
Mar 28, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 14, 2022 •
edited

Closes #951

@rootulp rootulp self-assigned this Nov 14, 2022
@rootulp rootulp changed the title docs: initial draft of ADR 010 docs: ADR for removal of WireMsgPayForBlob Nov 15, 2022
@rootulp rootulp changed the title docs: ADR for removal of WireMsgPayForBlob docs: ADR for removal of MsgWirePayForBlob Nov 15, 2022
@rootulp rootulp changed the title docs: ADR for removal of MsgWirePayForBlob ADR 010: removal of MsgWirePayForBlob Nov 18, 2022
@rootulp rootulp mentioned this pull request Nov 18, 2022
Merged
5 tasks
@evan-forbes
Copy link
Member

ref celestiaorg/celestia-core#893

This was referenced Dec 8, 2022
Closed
Merged
evan-forbes added a commit that referenced this pull request Dec 13, 2022
@evan-forbes @rootulp @cmwaters
feat!: use BlobTx instead of MsgWirePayForBlob (#1089)
12e77d0 
## Overview

reference PR for everything that needs to be changed to remove the wire
PFB. This PR **should not** be merged. While there will be at least one
rather large PR, many of these changes can be broken up into chunks.

this PR is mega breaking and currently blocked by
celestiaorg/celestia-core#893

closes #1098
is the implementation for #1005 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@evan-forbes
Copy link
Member

just to update this, we're delaying fleshing out this ADR, but we have merged the implementation in celestiaorg/celestia-core#893 and #1089

@rootulp rootulp changed the title ADR 010: removal of MsgWirePayForBlob docs: ADR 010 Removal of MsgWirePayForBlob Feb 17, 2023
@rootulp rootulp changed the title docs: ADR 010 Removal of MsgWirePayForBlob docs: ADR 010 Remove MsgWirePayForBlob Feb 17, 2023
@rootulp rootulp changed the title docs: ADR 010 Remove MsgWirePayForBlob docs: ADR 10 Remove MsgWirePayForBlob Feb 17, 2023
@rootulp rootulp added the ADR item is directly relevant to writing or modifying an ADR label Mar 24, 2023
@rootulp rootulp marked this pull request as ready for review March 24, 2023 11:31
@rootulp rootulp added the documentation Improvements or additions to documentation label Mar 24, 2023
@rootulp rootulp added this to the Mainnet milestone Mar 24, 2023
evan-forbes
evan-forbes previously approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could optionally include the validation logic for blob txs, but deferring to author

Thanks for remembering this!!

@rootulp rootulp enabled auto-merge (squash) March 27, 2023 07:26
@MSevey MSevey requested a review from a team March 27, 2023 07:26
@rootulp rootulp requested a review from cmwaters March 27, 2023 07:26
@rootulp rootulp disabled auto-merge March 27, 2023 07:26
@rootulp rootulp merged commit 258aeb2 into celestiaorg:main Mar 28, 2023
@rootulp rootulp deleted the rp/adr-remove-wire-msg-pay-for-blob branch March 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@MSevey MSevey Awaiting requested review from MSevey

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
ADR item is directly relevant to writing or modifying an ADR documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR for removal of MsgWirePayForBlob
3 participants
@rootulp @evan-forbes @cmwaters