Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add git to Dockerfile build #1017

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 16, 2022

Overview

Fixes the following error:

 ---> 0119ef2bed23
Step 5/12 : RUN make build
 ---> Running in 8f545cb05d38
make: git: No such file or directory
make: git: No such file or directory
--> Updating go.mod

<---
Please provide an explanation of the PR, including the apprioprate context,
background, goal, and rationale. If there is an issue with this information,
please provide a tl;dr and link the issue.
-->

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the docker label Nov 16, 2022
@rach-id rach-id self-assigned this Nov 16, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK LGTM

@rach-id rach-id merged commit 9ba2ed2 into main Nov 16, 2022
@rach-id rach-id deleted the add_git_to_dockerfile_install branch November 16, 2022 16:31
@rach-id rach-id restored the add_git_to_dockerfile_install branch November 16, 2022 16:31
@rach-id rach-id deleted the add_git_to_dockerfile_install branch November 16, 2022 16:31
rach-id added a commit to rach-id/celestia-app that referenced this pull request Nov 17, 2022
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Fixes the following error:
```
 ---> 0119ef2bed23
Step 5/12 : RUN make build
 ---> Running in 8f545cb05d38
make: git: No such file or directory
make: git: No such file or directory
--> Updating go.mod
```
<--- 
Please provide an explanation of the PR, including the apprioprate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
rach-id added a commit that referenced this pull request Nov 22, 2022
Analogous to #1017 but
to the QGB v1 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants