doc: document NMT wrapper in prepare_proposal #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
previously approved these changes
Nov 24, 2022
rahulghangas
previously approved these changes
Jan 17, 2023
|
@evan-forbes Is this still worth merging? |
|
sure, but lets stay consistent with the naming #1069 (comment) |
# Conflicts: # pkg/da/data_availability_header.go
rach-id
dismissed stale reviews from rahulghangas and evan-forbes
via
2e7c11e
MSevey
requested review from
a team and
rootulp
and removed request for
a team
evan-forbes
reviewed
Jan 31, 2023
There was a problem hiding this comment.
apologies for letting this slip through the cracks @sweexordious
left one comment to use the same name for the wrapper across the board, then should finally merge
|
@evan-forbes done, all we need is an approve :D |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
- Coverage 48.84% 48.26% -0.59%
==========================================
Files 75 77 +2
Lines 4369 4397 +28
==========================================
- Hits 2134 2122 -12
- Misses 2055 2098 +43
+ Partials 180 177 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
approved these changes
Feb 1, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Feb 27, 2023
Adds a small note to specify that the NMT wrapper is used to extend the shares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small note to specify that the NMT wrapper is used to extend the shares