fix: propagate share version #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused as to why the CI and Release is consistently failing across all PRs |
CI passed on retry |
|
accidentally deleted code coverage comment and not sure how to revive it. I don't find it helpful so maybe other reviewers also don't need it back |
evan-forbes
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1028 where I didn't propagate the new struct field
ShareVersionto all instances ofcoretypes.Blob.Unfortunately Go isn't exhaustive on specifying struct fields so I wasn't made aware of this miss until working on an unrelated change. Open to ideas on how to have higher confidence all instances have been addressed. The non_exhaustive attribute makes me think Rust structs are exhaustive by default.