-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename message
=> blob
#1060
chore: rename message
=> blob
#1060
Conversation
Renames: - `Message` => `Blob` - `message`, `msg`, `data` => `blob` Does not address: - ADRs - specs
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 50.90% 50.90%
=======================================
Files 71 71
Lines 4410 4410
=======================================
Hits 2245 2245
Misses 1938 1938
Partials 227 227
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg thanks for doing this! such a pain (we're never renaming it again).
let's fix the any conflicts and merge ASAP to avoid other conflicts here. Apologies that we didn't merge sooner
No worries, the merge conflicts were my fault and not difficult to resolve. This is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge merge merge before we get more conflicts
Part of #995
Renames the following on a case by case basis:
Message
=>Blob
message
,msg
,data
=>blob
Does not address:
It's likely that I didn't catch every instance due to human error