Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename message => blob #1060

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 24, 2022

Part of #995

Renames the following on a case by case basis:

  • Message => Blob
  • message, msg, data => blob

Does not address:

  • ADRs
  • specs

It's likely that I didn't catch every instance due to human error

Renames:
- `Message` => `Blob`
- `message`, `msg`, `data` => `blob`

Does not address:
- ADRs
- specs
@rootulp rootulp self-assigned this Nov 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1060 (d98713d) into main (42befe2) will not change coverage.
The diff coverage is 86.05%.

@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   50.90%   50.90%           
=======================================
  Files          71       71           
  Lines        4410     4410           
=======================================
  Hits         2245     2245           
  Misses       1938     1938           
  Partials      227      227           
Impacted Files Coverage Δ
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
pkg/inclusion/get_commit.go 0.00% <0.00%> (ø)
pkg/inclusion/nmt_caching.go 81.66% <ø> (ø)
pkg/shares/info_byte.go 100.00% <ø> (ø)
x/blob/payforblob.go 0.00% <0.00%> (ø)
pkg/shares/utils.go 52.00% <60.00%> (ø)
pkg/shares/share_splitting.go 63.80% <70.00%> (ø)
pkg/shares/split_sparse_shares.go 68.26% <71.42%> (ø)
pkg/shares/parse_sparse_shares.go 82.53% <93.10%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp marked this pull request as ready for review November 24, 2022 01:56
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg thanks for doing this! such a pain (we're never renaming it again).

let's fix the any conflicts and merge ASAP to avoid other conflicts here. Apologies that we didn't merge sooner

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 28, 2022

Apologies that we didn't merge sooner

No worries, the merge conflicts were my fault and not difficult to resolve. This is ready for re-review.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge merge merge before we get more conflicts

@evan-forbes evan-forbes merged commit 1e014d5 into celestiaorg:main Nov 29, 2022
@rootulp rootulp deleted the rp/rename-message-to-blob branch November 29, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants