Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove randomness from estimate square size test #1086

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 30, 2022

Motivation: to fix CI on #1083 per #1083 (comment)

@rootulp rootulp self-assigned this Nov 30, 2022
@rootulp rootulp marked this pull request as ready for review November 30, 2022 21:08
@rootulp rootulp enabled auto-merge (squash) November 30, 2022 21:08
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 30, 2022

no markdownlint false positives on the most recent CI workflow are a positive sign

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 hopefully simplying the estimation process with the removal of the wirePFB will also help

@rootulp rootulp merged commit 8855150 into celestiaorg:main Dec 1, 2022
@rootulp rootulp deleted the rp/remove-randomness-from-square-size-test branch December 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants