Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename to sequence len #1116

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 13, 2022

Closes #1097

@codecov-commenter
Copy link

Codecov Report

Merging #1116 (45da9fe) into main (00e31f8) will decrease coverage by 3.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   50.55%   47.43%   -3.13%     
==========================================
  Files          72       71       -1     
  Lines        4312     3970     -342     
==========================================
- Hits         2180     1883     -297     
+ Misses       1917     1915       -2     
+ Partials      215      172      -43     
Impacted Files Coverage Δ
pkg/shares/split_compact_shares.go 84.93% <100.00%> (ø)
x/blob/types/builder_options.go 15.87% <0.00%> (-25.40%) ⬇️
app/parse_txs.go 51.61% <0.00%> (-12.39%) ⬇️
testutil/testnode/node_interaction_api.go 56.77% <0.00%> (-6.38%) ⬇️
pkg/shares/share_splitting.go 60.22% <0.00%> (-2.57%) ⬇️
testutil/testnode/node_init.go 61.97% <0.00%> (-2.01%) ⬇️
x/blob/payforblob.go 0.00% <0.00%> (ø)
x/blob/types/codec.go 100.00% <0.00%> (ø)
app/prepare_proposal.go 0.00% <0.00%> (ø)
testutil/testnode/full_node.go 61.06% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp self-assigned this Dec 14, 2022
@rootulp rootulp merged commit 8c4982c into celestiaorg:main Dec 14, 2022
@rootulp rootulp deleted the rp/rename-data-len branch December 14, 2022 14:32
rootulp added a commit to rootulp/celestia-app that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename data length to sequence length
3 participants