Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 12: Sequence Length Encoding #1123

Merged
merged 1 commit into from
Dec 19, 2022
Merged

ADR 12: Sequence Length Encoding #1123

merged 1 commit into from
Dec 19, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 14, 2022

Closes #1122

@rootulp rootulp self-assigned this Dec 14, 2022
@rootulp rootulp changed the title docs: adr 012 ADR 12: Sequence Length Encoding Dec 14, 2022
@rootulp rootulp marked this pull request as ready for review December 14, 2022 20:21
evan-forbes
evan-forbes approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for organizing, documenting, and pushing this through!

I like these quick ADRs that record our sync discussions after the fact.

@rootulp
Copy link
Collaborator Author

rootulp commented Dec 15, 2022

Will merge by EOD if there is no more feedback.

cmwaters
cmwaters approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice writeup

@rootulp rootulp merged commit 0d9cbb1 into celestiaorg:main Dec 19, 2022
@rootulp rootulp deleted the rp/adr-sequence-length branch December 19, 2022 15:15
@rootulp rootulp mentioned this pull request Dec 19, 2022
Open
rootulp added a commit to rootulp/celestia-app that referenced this pull request Dec 19, 2022
@rootulp
ADR 12: Sequence Length Encoding (celestiaorg#1123)
26cd44a 
Closes celestiaorg#1122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@MSevey MSevey Awaiting requested review from MSevey

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR: sequence length and reserved bytes encoding
3 participants
@rootulp @cmwaters @evan-forbes