feat!: enforce single pfb per blobtx #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
ABCI
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 48.17% 48.11% -0.06%
==========================================
Files 72 72
Lines 4056 4061 +5
==========================================
Hits 1954 1954
- Misses 1930 1935 +5
Partials 172 172
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmwaters
previously approved these changes
Jan 9, 2023
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
cmwaters
previously approved these changes
Jan 9, 2023
rootulp
previously approved these changes
Jan 9, 2023
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
part of #388, split apart from #1154
This PR refactors enforcement of only allowing a single PFB per sdk.Tx and, per feedback in #1154, adds a new block validity rule where all transactions must be decodable!
Checklist