Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add a default transaction limit #1210

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jan 11, 2023

Overview

this PR is the quick solution to #1209. Note that this is not a new block validity rule, only an extra check during PrepareProposal.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes requested review from a team, rahulghangas and cmwaters and removed request for a team January 11, 2023 03:33
@MSevey MSevey requested a review from a team January 11, 2023 03:33
@evan-forbes evan-forbes requested review from rootulp and removed request for a team January 11, 2023 03:33
@evan-forbes evan-forbes self-assigned this Jan 11, 2023
@evan-forbes evan-forbes added the bug Something isn't working label Jan 11, 2023
@MSevey MSevey requested a review from a team January 11, 2023 03:40
@codecov-commenter
Copy link

Codecov Report

Merging #1210 (6be211e) into main (f4f6a3a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
- Coverage   48.08%   48.00%   -0.09%     
==========================================
  Files          72       72              
  Lines        4082     4089       +7     
==========================================
  Hits         1963     1963              
- Misses       1947     1954       +7     
  Partials      172      172              
Impacted Files Coverage Δ
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
x/blob/types/blob_tx.go 18.57% <0.00%> (+1.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants