chore: refactor stripCompactShares
#1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
chore
MSevey
requested review from
a team and
mojtaba-esk
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1227 +/- ##
=======================================
Coverage 48.11% 48.11%
=======================================
Files 72 72
Lines 4086 4086
=======================================
Hits 1966 1966
Misses 1948 1948
Partials 172 172 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmwaters
reviewed
Jan 12, 2023
cmwaters
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor that I extracted from a larger in-progress PR. Prior to this PR, implementation details for compact shares leaked out to the
provepackage. Instead of leaking these implementation details, we can use theRawData()method.