feat: Add QGB verification command #1236

rach-id · 2023-01-13T15:42:38Z

Overview

This command verifies that some shares were attested to in the QGB smart contract.

Blocked by #1233

Closes #1184

Checklist

New and updated code has appropriate documentation
New and updated code has new and/or updated testing
Required CI checks are passing
Visual proof for any user facing features like CLI or documentation updates
Linked issues closed with keywords

codecov-commenter · 2023-01-13T16:52:03Z

Codecov Report

Merging #1236 (0af4209) into main (2eb5c3c) will increase coverage by 0.84%.
The diff coverage is 48.74%.

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   48.10%   48.95%   +0.84%     
==========================================
  Files          72       73       +1     
  Lines        4089     4286     +197     
==========================================
+ Hits         1967     2098     +131     
- Misses       1950     2006      +56     
- Partials      172      182      +10

Impacted Files	Coverage Δ
app/app.go	`6.34% <0.00%> (-0.02%)`	⬇️
x/qgb/keeper/query_data_commitment.go	`0.00% <0.00%> (ø)`
pkg/prove/querier.go	`21.73% <30.76%> (+21.73%)`	⬆️
pkg/prove/proof.go	`75.21% <61.90%> (-10.72%)`	⬇️
x/qgb/keeper/keeper_data_commitment.go	`46.87% <66.66%> (+46.87%)`	⬆️
x/qgb/keeper/keeper.go	`69.23% <0.00%> (+11.53%)`	⬆️
x/qgb/keeper/keeper_attestation.go	`73.58% <0.00%> (+47.16%)`	⬆️
x/qgb/keeper/query_general.go	`55.55% <0.00%> (+55.55%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

evan-forbes

@sweexordious I'm assuming that this is required for the inclusion proofs? Let's also create an issue to add more usage documentation over how to use this command, what we are receving in return etc. Also, how to access the same things via RPC would also be needed.

will defer to @rahulghangas, let's try to merge this by thursday to give us some time for the rest of the things needed for the qgb mocked launch

evan-forbes · 2023-01-17T20:16:13Z

x/qgb/cmd/config.go

+func parseVerifyFlags(cmd *cobra.Command) (VerifyConfig, error) {
+	chainID, err := cmd.Flags().GetString(celestiaChainIDFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	evmChainID, err := cmd.Flags().GetUint64(evmChainIDFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	tendermintRPC, err := cmd.Flags().GetString(tendermintRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	celesGRPC, err := cmd.Flags().GetString(celesGRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	evmRPC, err := cmd.Flags().GetString(evmRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	contractAddr, err := cmd.Flags().GetString(contractAddressFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	if contractAddr == "" {
+		return VerifyConfig{}, fmt.Errorf("contract address flag is required: %s", contractAddressFlag)
+	}
+	if !ethcmn.IsHexAddress(contractAddr) {
+		return VerifyConfig{}, fmt.Errorf("valid contract address flag is required: %s", contractAddressFlag)
+	}
+	address := ethcmn.HexToAddress(contractAddr)
+
+	return VerifyConfig{
+		CelestiaChainID: chainID,
+		EVMChainID:      evmChainID,
+		CelesGRPC:       celesGRPC,
+		TendermintRPC:   tendermintRPC,
+		EVMRPC:          evmRPC,
+		ContractAddr:    address,
+	}, nil
+}


alternatively, if we wanted to, we could get some of these flags from the client context passed around in the cobra context.

Concerning this, I made it using flags.AddQueryFlagsToCmd(command) locally , however, it adds a special height flag:

Use a specific height to query state at (this can error if the node is pruning state)

which I don't support in my query.

what do you think?

I guess, the better thing to do is to keep the same explicitly declared flags. However, change their description to be consistent with the query flags defined in the cosmos-sdk. What do you think?

For example celes-http-rpc => node for tendermint RPC.

I agree with @sweexordious, keep the same flags explicitly declared, but make them consistent with cosmos-sdk

evan-forbes · 2023-01-17T20:17:16Z

cmd/celestia-appd/cmd/root.go

@@ -165,6 +167,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig encoding.Config) {
 		queryCommand(),
 		txCommand(),
 		keybase,
+		qgbcmd.VerifyCmd(),


something we might want to think about is adding this command to the query command, since this is a query

that's a good idea. The reason I didn't do it is that the query commands somehow are consistent: they use the RPC/GRPC endpoints to query things from state, like everything needed is gotten from core/app. However, in this case, we're also connecting to an EVM chain and interacting with a smart contract.

I am okey with either tbh, let me know if I should change

rach-id · 2023-01-17T20:43:53Z

Let's also create an issue to add more usage documentation over how to use this command, what we are receving in return etc. Also, how to access the same things via RPC would also be needed.

#1254

evan-forbes

took another look, and LGTM

would appreciate a second set of eyes, but we also need to push this through and focus on the other things needed for the mocked QGB v1 launch

rahulghangas

LGTM, minor questions

rahulghangas · 2023-01-23T05:23:40Z

x/qgb/cmd/config.go

+)
+
+func addVerifyFlags(cmd *cobra.Command) *cobra.Command {
+	cmd.Flags().StringP(celestiaChainIDFlag, "x", "user", "Specify the celestia chain id")


I think we should follow correct usage (capitalization) for REST and gRPC as defined here https://docs.cosmos.network/main/core/grpc_rest

rahulghangas · 2023-01-23T05:25:21Z

x/qgb/cmd/config.go

+func parseVerifyFlags(cmd *cobra.Command) (VerifyConfig, error) {
+	chainID, err := cmd.Flags().GetString(celestiaChainIDFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	evmChainID, err := cmd.Flags().GetUint64(evmChainIDFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	tendermintRPC, err := cmd.Flags().GetString(tendermintRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	celesGRPC, err := cmd.Flags().GetString(celesGRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	evmRPC, err := cmd.Flags().GetString(evmRPCFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	contractAddr, err := cmd.Flags().GetString(contractAddressFlag)
+	if err != nil {
+		return VerifyConfig{}, err
+	}
+	if contractAddr == "" {
+		return VerifyConfig{}, fmt.Errorf("contract address flag is required: %s", contractAddressFlag)
+	}
+	if !ethcmn.IsHexAddress(contractAddr) {
+		return VerifyConfig{}, fmt.Errorf("valid contract address flag is required: %s", contractAddressFlag)
+	}
+	address := ethcmn.HexToAddress(contractAddr)
+
+	return VerifyConfig{
+		CelestiaChainID: chainID,
+		EVMChainID:      evmChainID,
+		CelesGRPC:       celesGRPC,
+		TendermintRPC:   tendermintRPC,
+		EVMRPC:          evmRPC,
+		ContractAddr:    address,
+	}, nil
+}


I agree with @sweexordious, keep the same flags explicitly declared, but make them consistent with cosmos-sdk

rahulghangas · 2023-01-23T05:26:20Z

x/qgb/cmd/verify.go

+
+	"github.com/celestiaorg/celestia-app/pkg/prove"
+	"github.com/celestiaorg/celestia-app/x/qgb/types"
+	wrapper "github.com/celestiaorg/quantum-gravity-bridge/wrappers/QuantumGravityBridge.sol"


[nit, non-blocking]
Maybe qgbWrapper would be a more descriptive name here, or contractWrapper?

# Conflicts: # cmd/celestia-appd/cmd/root.go

rach-id · 2023-01-23T13:36:57Z

Applied feedback. Can I get an approve to merge this?

@distractedm1nd

refactor: rename stripCompactShares to stripPrefix chore: rename to NewShareInclusionProof feat!: keep track of share indexes when splitting txs fix lint wip: test write tx revert!: multi share commitment (celestiaorg#1275) Closes celestiaorg#1231 feat: Add QGB verification command (celestiaorg#1236) This command verifies that some shares were attested to in the QGB smart contract. Blocked by celestiaorg#1233 Closes celestiaorg#1184  - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords feat: check that `MsgPayForBlob` components are non-zero (celestiaorg#1279) feat: compact share splitter tracks tx share ranges test: TestExport_txKeyToShareIndex extract mergeMaps fix lint test: TxSharePosition test NewTxInclusionProof fix comment delete unused file wip: TestSplitTxs improve largeTx test case fix: shift pfbTxShare range by len of txShares refactor: use css.Count() for end share index refactor: rename to shareRanges feat: enforce that PFBs are always ordered after normal transactions (celestiaorg#1273) Closes: celestiaorg#1230 chore(deps): Bump github.com/celestiaorg/nmt from 0.12.0 to 0.13.0 (celestiaorg#1284) fix: IsCompactShare for PFB tx shares (celestiaorg#1281) Closes celestiaorg#1280 chore: fix naming from `client/cli/wirepayfordata.go` to blob (celestiaorg#1288)  After updating my forks, I've seen that `wirepayfordata` haven't received renaming treatment. Hence this PR solves this little thingy. We can also have naming like `wirepayfordatablob`. Still LMK if you prefer the later   - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords chore: rename message to blob in QGB verify command (celestiaorg#1289)    - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords sanity check that raw data is in shares fix lint NewTxInclusionProof returns a TxProof fix: lint Update pkg/prove/proof.go Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Update pkg/shares/split_compact_shares.go Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> refactor: remove err return param chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (celestiaorg#1283) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's releases</a>.</em></p> <blockquote> <h2>v3.4.0</h2> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.42.0 to 5.42.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/601">golangci/golangci-lint-action#601</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.42.0 to 5.42.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/602">golangci/golangci-lint-action#602</a></li> <li>build(deps-dev): bump eslint from 8.27.0 to 8.28.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/604">golangci/golangci-lint-action#604</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.42.1 to 5.43.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/605">golangci/golangci-lint-action#605</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.42.1 to 5.43.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/607">golangci/golangci-lint-action#607</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.43.0 to 5.44.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/609">golangci/golangci-lint-action#609</a></li> <li>build(deps-dev): bump prettier from 2.7.1 to 2.8.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/611">golangci/golangci-lint-action#611</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.43.0 to 5.44.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/610">golangci/golangci-lint-action#610</a></li> <li>build(deps-dev): bump typescript from 4.8.4 to 4.9.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/606">golangci/golangci-lint-action#606</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.9 to 18.11.10 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/614">golangci/golangci-lint-action#614</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.44.0 to 5.45.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/615">golangci/golangci-lint-action#615</a></li> <li>build(deps-dev): bump eslint from 8.28.0 to 8.29.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/617">golangci/golangci-lint-action#617</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.44.0 to 5.45.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/616">golangci/golangci-lint-action#616</a></li> <li>build(deps-dev): bump typescript from 4.9.3 to 4.9.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/619">golangci/golangci-lint-action#619</a></li> <li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.34.0 to 0.36.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/620">golangci/golangci-lint-action#620</a></li> <li>build(deps-dev): bump prettier from 2.8.0 to 2.8.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/622">golangci/golangci-lint-action#622</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.45.0 to 5.46.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/621">golangci/golangci-lint-action#621</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.45.0 to 5.46.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/623">golangci/golangci-lint-action#623</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.46.0 to 5.46.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/625">golangci/golangci-lint-action#625</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.10 to 18.11.17 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/628">golangci/golangci-lint-action#628</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.46.0 to 5.46.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/626">golangci/golangci-lint-action#626</a></li> <li>build(deps-dev): bump eslint from 8.29.0 to 8.30.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/627">golangci/golangci-lint-action#627</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.46.1 to 5.47.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/633">golangci/golangci-lint-action#633</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.46.1 to 5.47.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/634">golangci/golangci-lint-action#634</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.0.6 to 3.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/632">golangci/golangci-lint-action#632</a></li> <li>build(deps-dev): bump eslint from 8.30.0 to 8.31.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/635">golangci/golangci-lint-action#635</a></li> <li>build(deps): bump <code>@types/node</code> from 18.11.17 to 18.11.18 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/636">golangci/golangci-lint-action#636</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.47.0 to 5.47.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/637">golangci/golangci-lint-action#637</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.47.0 to 5.47.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/639">golangci/golangci-lint-action#639</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.1.0 to 3.1.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/638">golangci/golangci-lint-action#638</a></li> <li>build(deps): bump json5 from 1.0.1 to 1.0.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/642">golangci/golangci-lint-action#642</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.47.1 to 5.48.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/643">golangci/golangci-lint-action#643</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.47.1 to 5.48.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/644">golangci/golangci-lint-action#644</a></li> <li>build(deps-dev): bump prettier from 2.8.1 to 2.8.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/645">golangci/golangci-lint-action#645</a></li> <li>build(deps-dev): bump eslint-config-prettier from 8.5.0 to 8.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/646">golangci/golangci-lint-action#646</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.1.1 to 3.1.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/647">golangci/golangci-lint-action#647</a></li> <li>Support Caching in Mono Repo by <a href="https://github.com/bbernays"><code>@bbernays</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/629">golangci/golangci-lint-action#629</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.27.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/650">golangci/golangci-lint-action#650</a></li> <li>build(deps-dev): bump prettier from 2.8.2 to 2.8.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/651">golangci/golangci-lint-action#651</a></li> <li>build(deps-dev): bump eslint from 8.31.0 to 8.32.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/652">golangci/golangci-lint-action#652</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.0 to 5.48.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/653">golangci/golangci-lint-action#653</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.0 to 5.48.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/654">golangci/golangci-lint-action#654</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.27.4 to 2.27.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/655">golangci/golangci-lint-action#655</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.1 to 5.48.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/656">golangci/golangci-lint-action#656</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.1 to 5.48.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/657">golangci/golangci-lint-action#657</a></li> <li>build(deps-dev): bump eslint-plugin-simple-import-sort from 8.0.0 to 9.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/658">golangci/golangci-lint-action#658</a></li> </ul> <h2>New Contributors</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint-action/commit/08e2f20817b15149a52b5b3ebe7de50aff2ba8c5"><code>08e2f20</code></a> build(deps-dev): bump eslint-plugin-simple-import-sort from 8.0.0 to 9.0.0 (#...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/8d110786c7428017295d1011939074e4880134c5"><code>8d11078</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.1 to 5.48.2 ...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/724a5425dbb3605c8193e1236b39684908fe1faf"><code>724a542</code></a> build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.1 to 5.48.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/656">#656</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/ac0edcd804b1b5a5a373d15812e3ca8e3009aaff"><code>ac0edcd</code></a> build(deps-dev): bump eslint-plugin-import from 2.27.4 to 2.27.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/655">#655</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/d6404ce2933838656ca2d23ed1d7c9bf7177e38b"><code>d6404ce</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 5.48.0 to 5.48.1 ...</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/cb88bde406513ba2b8f95895720d89bf588e2908"><code>cb88bde</code></a> build(deps-dev): bump <code>@typescript-eslint/parser</code> from 5.48.0 to 5.48.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/653">#653</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/f26018a9c0d2934ae3bdaadb0d6bbbbe168f34ac"><code>f26018a</code></a> build(deps-dev): bump eslint from 8.31.0 to 8.32.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/652">#652</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/78451d099ca9433b4b6a0b5d9c7a2d7720928976"><code>78451d0</code></a> build(deps-dev): bump prettier from 2.8.2 to 2.8.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/651">#651</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/5570e667056be8be4c7e99ba31339d64a2c7ab29"><code>5570e66</code></a> build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.27.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/650">#650</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/1626f2bd943cd202b1338d967340eb6c987e5067"><code>1626f2b</code></a> Support Caching in Mono Repo (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/629">#629</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v3.3.1...v3.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golangci/golangci-lint-action&package-manager=github_actions&previous-version=3.3.1&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore!: rename package prove to proof (celestiaorg#1291) Closes celestiaorg#1290 refactor: use WriteTx refactor: remove named return params refactor: use shareRangeOffset update to local celestia-core test: integ tests to use prove=true fix godoc chore: rename sharesProofs to shareProofs Update pkg/shares/share_splitting.go Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com> docs: describe mergeMaps chore: add more test cases for the compact share splitter (celestiaorg#1295) feat: Prevent any errors when creating the data folder (celestiaorg#1303) Hello team, This is an small feature/fix that prevents any error when the container starts and try to create the folder in `${CELESTIA_HOME}/data` using the option `-p` in the `mkdir` command. Thank you!  - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords chore!: rename MsgPayForBlob to MsgPayForBlobs (celestiaorg#1304) Closes: celestiaorg#1221 Co-authored-by: Rootul P <rootulp@gmail.com> chore: downgrade nmt to 0.12.0 (celestiaorg#1307) Downgrade to NMT 0.12.0 while @distractedm1nd @liamsi investigate an issue in 0.13.0 chore: rename variable to shareProof lint with --verbose flag update to 1.50.1

## Overview This command verifies that some shares were attested to in the QGB smart contract. Blocked by #1233 Closes #1184 ## Checklist  - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords

rach-id added enhancement New feature or request x/qgb labels Jan 13, 2023

rach-id requested a review from evan-forbes as a code owner January 13, 2023 15:42

rach-id self-assigned this Jan 13, 2023

rach-id marked this pull request as draft January 13, 2023 15:42

rach-id requested a review from rahulghangas January 13, 2023 15:42

MSevey requested a review from a team January 13, 2023 15:42

rach-id added 2 commits January 17, 2023 16:22

feat: add verification command for shares posted to QGB

0ce7cb2

chore: gofumpt

89a9be2

rach-id force-pushed the verification_command_on_top_of_copy branch from 0af4209 to 89a9be2 Compare January 17, 2023 15:23

rach-id marked this pull request as ready for review January 17, 2023 15:25

rach-id added 2 commits January 17, 2023 16:25

Merge branch 'main' into verification_command_on_top_of_copy

bfb946c

fix: use BlobShareRange instead of MsgShareRange

e403c1b

evan-forbes reviewed Jan 17, 2023

View reviewed changes

evan-forbes added this to the QGB Testnet milestone Jan 17, 2023

rach-id mentioned this pull request Jan 17, 2023

Document QGB verify command usage #1254

Closed

chore: rename qgb cmd package to client

4d32a19

rach-id mentioned this pull request Jan 19, 2023

QGB shares inclusion proof verification command #1194

Closed

5 tasks

evan-forbes previously approved these changes Jan 19, 2023

View reviewed changes

rahulghangas previously approved these changes Jan 23, 2023

View reviewed changes

chore: stay consistent with cosmos-sdk flags for QGB verify command

59fa792

rach-id dismissed stale reviews from rahulghangas and evan-forbes via 59fa792 January 23, 2023 13:34

MSevey requested a review from a team January 23, 2023 13:34

Merge branch 'main' into verification_command_on_top_of_copy

2f302a3

# Conflicts: # cmd/celestia-appd/cmd/root.go

rach-id requested review from rahulghangas and evan-forbes January 23, 2023 13:36

evan-forbes approved these changes Jan 23, 2023

View reviewed changes

rach-id merged commit a98b999 into celestiaorg:main Jan 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add QGB verification command #1236

feat: Add QGB verification command #1236

rach-id commented Jan 13, 2023

codecov-commenter commented Jan 13, 2023

evan-forbes left a comment

evan-forbes Jan 17, 2023

rach-id Jan 20, 2023

rahulghangas Jan 23, 2023

evan-forbes Jan 17, 2023

rach-id Jan 17, 2023

rach-id commented Jan 17, 2023

evan-forbes left a comment

rahulghangas left a comment •

edited

rahulghangas Jan 23, 2023

rahulghangas Jan 23, 2023

rahulghangas Jan 23, 2023

rach-id commented Jan 23, 2023

feat: Add QGB verification command #1236

feat: Add QGB verification command #1236

Conversation

rach-id commented Jan 13, 2023

Overview

Checklist

codecov-commenter commented Jan 13, 2023

Codecov Report

evan-forbes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rach-id commented Jan 17, 2023

evan-forbes left a comment

Choose a reason for hiding this comment

rahulghangas left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rach-id commented Jan 23, 2023

rahulghangas left a comment •

edited