-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: namespaced padding share isSequenceStart=false
#1246
chore: namespaced padding share isSequenceStart=false
#1246
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 47.99% 48.76% +0.77%
==========================================
Files 72 75 +3
Lines 4084 4339 +255
==========================================
+ Hits 1960 2116 +156
- Misses 1952 2043 +91
- Partials 172 180 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I just have one question
I think that's just how the bot works. Also whenever I change is made to a PR, all prior reviews are dismissed so the request for reviews happens again |
Closes #1245
NamespacedPaddedShare
to a stand-alone fileisSequenceStart=false
parse_sparse_shares_test.go