Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: namespaced padding share isSequenceStart=false #1246

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jan 16, 2023

Closes #1245

  • Extract NamespacedPaddedShare to a stand-alone file
  • Modify namespaced padded share to set isSequenceStart=false
  • Resolve a TODO by moving tests to parse_sparse_shares_test.go

@rootulp rootulp self-assigned this Jan 16, 2023
@rootulp rootulp marked this pull request as ready for review January 16, 2023 20:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #1246 (ef002ec) into main (c74c614) will increase coverage by 0.77%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   47.99%   48.76%   +0.77%     
==========================================
  Files          72       75       +3     
  Lines        4084     4339     +255     
==========================================
+ Hits         1960     2116     +156     
- Misses       1952     2043      +91     
- Partials      172      180       +8     
Impacted Files Coverage Δ
pkg/shares/parse_sparse_shares.go 66.03% <ø> (-2.93%) ⬇️
pkg/shares/namespaced_padding.go 88.23% <88.23%> (ø)
pkg/shares/share_splitting.go 71.60% <100.00%> (ø)
pkg/shares/split_sparse_shares.go 65.16% <100.00%> (-4.28%) ⬇️
pkg/prove/proof.go 75.84% <0.00%> (-10.08%) ⬇️
app/estimate_square_size.go 88.46% <0.00%> (-6.67%) ⬇️
app/write_square.go 90.90% <0.00%> (-2.08%) ⬇️
testutil/testnode/node_interaction_api.go 56.41% <0.00%> (-1.45%) ⬇️
x/blob/types/blob_tx.go 18.57% <0.00%> (-1.13%) ⬇️
x/blob/types/payforblob.go 81.09% <0.00%> (-0.73%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cmwaters
cmwaters previously approved these changes Jan 17, 2023
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I just have one question

pkg/shares/namespaced_padding.go Outdated Show resolved Hide resolved
@MSevey
Copy link
Member

MSevey commented Jan 17, 2023

I don't think I did.... something weird seems to be happening with the github action maybe.
Screen Shot 2023-01-17 at 3 58 07 PM

@cmwaters
Copy link
Contributor

I think that's just how the bot works. Also whenever I change is made to a PR, all prior reviews are dismissed so the request for reviews happens again

@rootulp rootulp merged commit a8c8849 into celestiaorg:main Jan 18, 2023
@rootulp rootulp deleted the rp/namespaced-padded-shares branch January 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespaced padded shares contain isSequenceStart=true
4 participants