chore!: remove ShareCommitAndSignature #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
chore
MSevey
requested review from
a team and
rach-id
and removed request for
a team
rootulp
commented
Jan 19, 2023
Comment on lines
+22
to
+23
| // share_commitment is a commitment to the blob shares associated with this | ||
| // MsgPayForBlob. |
There was a problem hiding this comment.
we can elaborate on this in x/blob/README.md and especially after #1231
rach-id
approved these changes
Jan 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 48.84% 48.85% +0.01%
==========================================
Files 75 75
Lines 4369 4368 -1
==========================================
Hits 2134 2134
+ Misses 2055 2054 -1
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1269