Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update x/blob/README.md #1272

Merged
merged 1 commit into from
Jan 19, 2023
Merged

docs: update x/blob/README.md #1272

merged 1 commit into from
Jan 19, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jan 19, 2023

Closes #1268

@rootulp rootulp added the documentation Improvements or additions to documentation label Jan 19, 2023
@rootulp rootulp requested a review from cmwaters January 19, 2023 20:25
@rootulp rootulp self-assigned this Jan 19, 2023
@MSevey MSevey requested a review from a team January 19, 2023 20:25
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 19, 2023

In retrospect, the PR for dedicated namespace for PFBs should have updated this file in the same PR. I think that's one benefit of keeping docs in the same repo as the code, both can evolve atomically.

evan-forbes
evan-forbes approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! and good idea yeah, in the future we should definitely get in the habit of updating the docs when we change the code

@rootulp rootulp merged commit 69dbb89 into celestiaorg:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update x/blob/README.md
2 participants
@rootulp @evan-forbes