Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testRandBlob CLI for testground tests #1311

Merged
merged 8 commits into from
Jan 30, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Jan 30, 2023

Overview

ATM, test-infra repo is using my fork of celestia-app, which is not ok.
We need a CLI command for tests to trigger PFBs from apps' side, hence we have added another command named TestRandBlob

This PR contains another renaming, touching removal of Wire prefixes

Ref: celestiaorg/test-infra#159

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested review from a team and MSevey and removed request for a team January 30, 2023 13:20
@Bidon15 Bidon15 self-assigned this Jan 30, 2023
@Bidon15 Bidon15 added x/blob item is directly relevant to the blob module enhancement New feature or request labels Jan 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #1311 (e053ff6) into main (abfca15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files          76       76           
  Lines        4374     4374           
=======================================
  Hits         2178     2178           
  Misses       2014     2014           
  Partials      182      182           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rootulp
rootulp previously approved these changes Jan 30, 2023
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/payforblob.go Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@Bidon15 Bidon15 requested a review from rootulp January 30, 2023 15:25
evan-forbes
evan-forbes previously approved these changes Jan 30, 2023
x/blob/client/cli/tx.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
rootulp
rootulp previously approved these changes Jan 30, 2023
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
x/blob/client/cli/testrandblob.go Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp rootulp merged commit 852a229 into celestiaorg:main Jan 30, 2023
@Bidon15 Bidon15 deleted the feat/test-infra branch January 30, 2023 17:30
evan-forbes added a commit that referenced this pull request Feb 27, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

ATM, `test-infra` repo is using my fork of celestia-app, which is not
ok.
We need a CLI command for tests to trigger PFBs from apps' side, hence
we have added another command named `TestRandBlob`

This PR contains another renaming, touching removal of `Wire` prefixes

Ref: celestiaorg/test-infra#159
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request x/blob item is directly relevant to the blob module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants