-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add testRandBlob CLI for testground tests #1311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
a team and
MSevey
and removed request for
a team
January 30, 2023 13:20
Bidon15
added
x/blob
item is directly relevant to the blob module
enhancement
New feature or request
labels
Jan 30, 2023
Bidon15
force-pushed
the
feat/test-infra
branch
from
January 30, 2023 13:22
1e05e90
to
f4662ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 76 76
Lines 4374 4374
=======================================
Hits 2178 2178
Misses 2014 2014
Partials 182 182 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rootulp
previously approved these changes
Jan 30, 2023
Co-authored-by: Rootul P <rootulp@gmail.com>
evan-forbes
previously approved these changes
Jan 30, 2023
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
rootulp
previously approved these changes
Jan 30, 2023
Co-authored-by: Rootul P <rootulp@gmail.com>
rootulp
approved these changes
Jan 30, 2023
evan-forbes
added a commit
that referenced
this pull request
Feb 27, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview ATM, `test-infra` repo is using my fork of celestia-app, which is not ok. We need a CLI command for tests to trigger PFBs from apps' side, hence we have added another command named `TestRandBlob` This PR contains another renaming, touching removal of `Wire` prefixes Ref: celestiaorg/test-infra#159 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ATM,
test-infra
repo is using my fork of celestia-app, which is not ok.We need a CLI command for tests to trigger PFBs from apps' side, hence we have added another command named
TestRandBlob
This PR contains another renaming, touching removal of
Wire
prefixesRef: celestiaorg/test-infra#159
Checklist