feat: remove orchestrator address #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
commented
Feb 2, 2023
go.mod
Outdated
| @@ -185,7 +185,7 @@ require ( | |||
|
|
|||
| replace ( | |||
| github.com/celestiaorg/nmt v0.13.0 => github.com/celestiaorg/nmt v0.12.0 | |||
| github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.7.0-sdk-v0.46.7 | |||
| github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.7.0-sdk-v0.46.7.0.20230202145553-0b25d300d771 | |||
There was a problem hiding this comment.
[note for reviewers]
will be changed by the new cosmos-sdk release
evan-forbes
reviewed
Feb 2, 2023
|
Awesome! I wonder to which release this is planned to be included? |
rahulghangas
previously approved these changes
Feb 3, 2023
|
@sweexordious we just bumbed to v1.8.0-sdk-0.46.7, mind updating here? we can also do in a follow up PR |
evan-forbes
approved these changes
Feb 3, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Feb 27, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Closes #1329 Depends on a new release of the cosmos-sdk. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1329
Depends on a new release of the cosmos-sdk.
Checklist