chore!: bump nmt from v0.13 to v0.14 and remove the codec from NewTxInclusionProof
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
a team and
MSevey
and removed request for
a team
cmwaters
previously approved these changes
Feb 3, 2023
Good catch. Let's see how this one goes |
Codecov Report
@@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 48.26% 48.26%
=======================================
Files 77 77
Lines 4397 4397
=======================================
Hits 2122 2122
Misses 2098 2098
Partials 177 177
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
changed the title
nmt from v0.13 to v0.14nmt from v0.13 to v0.14 and remove the codec from NewTxInclusionProof
evan-forbes
approved these changes
Feb 3, 2023
Comment on lines
-27
to
+26
| func NewTxInclusionProof(codec rsmt2d.Codec, data types.Data, txIndex uint64) (types.ShareProof, error) { | ||
| func NewTxInclusionProof(data types.Data, txIndex uint64) (types.ShareProof, error) { |
There was a problem hiding this comment.
thanks for removing this since we weren't using this!
out of curiosity, was there any reason in node to remove this as well?
There was a problem hiding this comment.
To be honest, I have no idea even when node removed this 😓
evan-forbes
pushed a commit
that referenced
this pull request
Feb 27, 2023
…TxInclusionProof` (#1333) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Latest v0.12.0-rc5 is not compliant with what node will have to upcoming v0.7.0-rc`x`, as celestia-node is using nmt `v0.14.0` and dropped v0.13.0 This PR fixes this, hence I propose to make a `v0.12.0-rc6` afterwards 🙏 In addition, this PR cleans up codec from the signature that is not used in `NewTxInclusionProof ` anymore <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Latest v0.12.0-rc5 is not compliant with what node will have to upcoming v0.7.0-rc
x, as celestia-node is using nmtv0.14.0and dropped v0.13.0This PR fixes this, hence I propose to make a
v0.12.0-rc6afterwards 🙏In addition, this PR cleans up codec from the signature that is not used in
NewTxInclusionProofanymoreChecklist