improvement: move sealing to init function #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Feb 7, 2023
vgonkivs
force-pushed
the
perform_sealing_in_init_function
branch
from
e334dd7
to
41aa057
Compare
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
+ Coverage 48.28% 48.35% +0.07%
==========================================
Files 78 79 +1
Lines 4422 4428 +6
==========================================
+ Hits 2135 2141 +6
Misses 2107 2107
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
previously approved these changes
Feb 7, 2023
rootulp
previously approved these changes
Feb 7, 2023
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
[for reviewers] init() is called once regardless of how many times this package is imported per https://tutorialedge.net/golang/the-go-init-function/
IMO this seems less clear than an explicit New() or NewConfig() invocation but maybe that's because I haven't seen it before. If it's clearer for celestia-node then 
vgonkivs
force-pushed
the
perform_sealing_in_init_function
branch
from
d812c12
to
6b742e5
Compare
MSevey
requested review from
a team and
rahulghangas
and removed request for
a team
evan-forbes
approved these changes
Feb 8, 2023
rootulp
approved these changes
Feb 8, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Feb 27, 2023
## Overview Closes #1331 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1331
Checklist