-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: consistent share prefix for tail padding #1353
Conversation
0x25, 0x77, 0x60, 0x46, 0x19, 0x93, 0xf8, 0xf1, 0x97, 0xb4, 0x21, 0xec, 0x74, 0x35, 0xf3, 0xc3, | ||
0x6c, 0x37, 0x34, 0x92, 0x3e, 0x3d, 0xa9, 0xa4, 0x2d, 0xc7, 0x3b, 0x5, 0xf0, 0x7b, 0x3d, 0x8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewers] this hash had to be updated because the schema for tail padding shares is now different which results in a completely different hash.
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
- Coverage 48.31% 48.28% -0.04%
==========================================
Files 79 78 -1
Lines 4425 4422 -3
==========================================
- Hits 2138 2135 -3
Misses 2107 2107
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor, it is much appreciated
Context: #1353 Closes #1344 ## Screenshot <img width="746" alt="Screenshot 2023-02-08 at 11 55 07 AM" src="https://user-images.githubusercontent.com/3699047/217598202-15737680-d81b-4771-9940-75aa1830eaa2.png">
Closes #1350
After updating tail padding to have the same share prefix as namespace padding, I realized it was possible to make a few refactors so that all padding is consistent with respect to naming and tests:
padding.go
ReservedNamespacePadding
=>ReservedPaddingNamespaceID
to conform to the other appconsts that are namespace IDsshare.IsPadding
method