Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: emit event with blob sizes #1354

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 7, 2023

Closes #1271

@rootulp rootulp self-assigned this Feb 7, 2023
@rootulp rootulp marked this pull request as ready for review February 7, 2023 23:00
@rootulp rootulp changed the title fix: emit event with blob sizes fix!: emit event with blob sizes Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1354 (e374cfe) into main (990c720) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   48.31%   48.31%           
=======================================
  Files          79       79           
  Lines        4425     4425           
=======================================
  Hits         2138     2138           
  Misses       2107     2107           
  Partials      180      180           
Impacted Files Coverage Δ
x/blob/types/events.go 0.00% <0.00%> (ø)
x/blob/keeper/keeper.go 82.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp requested a review from cmwaters February 7, 2023 23:14
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

thanks for noticing and fixing this before incentivized testnet!

@rootulp rootulp merged commit 536e573 into celestiaorg:main Feb 8, 2023
evan-forbes pushed a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider supporting multiple blob sizes in an EventPayForBlob
3 participants