Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose the EVM private key used to create the testnode validator #1356

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 8, 2023

Overview

I will need this on the orchestrat-relayer repo tests to be able to sign attestations with the private key that was used to initialized the testnode validator.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added x/qgb testing items that are strictly related to adding or extending test coverage labels Feb 8, 2023
@rach-id rach-id self-assigned this Feb 8, 2023
@MSevey MSevey requested a review from a team February 8, 2023 14:19
@rach-id rach-id merged commit 470d12a into celestiaorg:main Feb 8, 2023
@rach-id rach-id deleted the expose_testnode_evm_private_key branch February 8, 2023 16:40
evan-forbes pushed a commit that referenced this pull request Feb 27, 2023
#1356)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

I will need this on the orchestrat-relayer repo tests to be able to sign
attestations with the private key that was used to initialized the
testnode validator.
 
## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants