chore!: rename TxSharePosition to TxShareRange
#1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
warn:api breaking
rach-id
approved these changes
Feb 8, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Feb 27, 2023
Closes #1241 The new name `TxShareRange` is consistent with https://github.com/celestiaorg/celestia-app/blob/fd6382278f6fff4ab3d272e5f3034203c9378126/pkg/proof/proof.go#L66 Technically API breaking because this is an exported function but I doubt there are external users of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1241
The new name
TxShareRangeis consistent withcelestia-app/pkg/proof/proof.go
Line 66 in fd63822
Technically API breaking because this is an exported function but I doubt there are external users of this function.