Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consistent usage of commitment #1360

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 8, 2023

Closes #1202

@rootulp rootulp self-assigned this Feb 8, 2023
@rootulp rootulp marked this pull request as ready for review February 8, 2023 20:13
@codecov-commenter
Copy link

Codecov Report

Merging #1360 (cf9011d) into main (150e65d) will not change coverage.
The diff coverage is 8.33%.

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   48.37%   48.37%           
=======================================
  Files          79       79           
  Lines        4424     4424           
=======================================
  Hits         2140     2140           
  Misses       2105     2105           
  Partials      179      179           
Impacted Files Coverage Δ
app/process_proposal.go 0.00% <0.00%> (ø)
pkg/inclusion/get_commit.go 0.00% <0.00%> (ø)
x/blob/types/blob_tx.go 18.30% <0.00%> (ø)
pkg/inclusion/paths.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp merged commit 548c8a9 into celestiaorg:main Feb 9, 2023
@rootulp rootulp deleted the rp/consistent-commitment branch February 9, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently use commitment instead of commit when referencing the share commitment
3 participants