fix: Fix prefix v in RCs
#1364
Merged
fix: Fix prefix v in RCs
#1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
Feb 9, 2023
Bidon15
approved these changes
Feb 9, 2023
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
May 25, 2023
## Overview This PR adds the prefix `v` to the RCs as well, it was added only when we have a release like `v1.2.3` , now applies to: Example for the version `1.2.3`: - `v1.2.3` - `v1.2.3-rc[0-9]` - `v1.2.3-alpha.[0-9]` - `v1.2.3-beta.[0-9]` --- Clean up the Yaml linter rules, now should works due to the increase the maximum to 120. --- ## Checklist  - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing cc: @Bidon15 @evan-forbes (cherry picked from commit 332a17f)
evan-forbes
pushed a commit
that referenced
this pull request
May 26, 2023
## Overview This PR adds the prefix `v` to the RCs as well, it was added only when we have a release like `v1.2.3` , now applies to: Example for the version `1.2.3`: - `v1.2.3` - `v1.2.3-rc[0-9]` - `v1.2.3-alpha.[0-9]` - `v1.2.3-beta.[0-9]` --- Clean up the Yaml linter rules, now should works due to the increase the maximum to 120. --- ## Checklist  - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing cc: @Bidon15 @evan-forbes (cherry picked from commit 332a17f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the prefix
vto the RCs as well, it was added only when we have a release likev1.2.3, now applies to:Example for the version
1.2.3:v1.2.3v1.2.3-rc[0-9]v1.2.3-alpha.[0-9]v1.2.3-beta.[0-9]Clean up the Yaml linter rules, now should works due to the increase the maximum to 120.
Checklist
cc: @Bidon15 @evan-forbes