Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use common Docker Build Pipeline #1370

Merged
merged 12 commits into from
Feb 13, 2023

Conversation

jrmanes
Copy link
Contributor

@jrmanes jrmanes commented Feb 10, 2023

Overview

Helloo team!

This PR uses the common CI pipeline for building the Docker containers and tagging them.

馃毃 First, we have to wait to merge the PR-29, because we need the file available in the right path.


Checklist

  • Merge PR-29.
  • Need to be tested before merging this one.
  • Linked issues closed with keywords

@jrmanes jrmanes self-assigned this Feb 10, 2023
@jrmanes jrmanes added CI item that directly relates to or modify the CI docker labels Feb 10, 2023
@jrmanes jrmanes marked this pull request as ready for review February 13, 2023 16:11
@jrmanes
Copy link
Contributor Author

jrmanes commented Feb 13, 2023

hello @MSevey
hope you're doing well 馃槃

I wanted to share this with you: action

It's about the permissions in the packages, I'm not sure 100%, but I think that we can solve it adding the .github repo to the celestia-app package Settings, in the section Manage Actions access and grant the Write role.

Let me know if I can do anything from my side ;)

PS: Similar issue for celestia-node

Best! 馃殌

@Bidon15
Copy link
Member

Bidon15 commented Feb 13, 2023

tagging @liamsi and @evan-forbes to help you with this @jrmanes
as Matt is OoO for foreseeable future.

rootulp
rootulp previously approved these changes Feb 13, 2023
.github/workflows/docker-build-publish-common.yml Outdated Show resolved Hide resolved
@rootulp rootulp merged commit 7380eec into celestiaorg:main Feb 13, 2023
rootulp pushed a commit to rootulp/celestia-app that referenced this pull request May 4, 2023
## Overview

Helloo team!

This PR uses the common CI pipeline for building the Docker containers
and tagging them.

馃毃 ~~First, we have to wait to merge the
[PR-29](celestiaorg/.github#29), because we need
the file available in the right path.~~

---

## Checklist

- [x] Merge [PR-29](celestiaorg/.github#29).
- [x] Need to be tested before merging this one.
- [x] Linked issues closed with keywords

---
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request May 25, 2023
## Overview

Helloo team!

This PR uses the common CI pipeline for building the Docker containers
and tagging them.

馃毃 ~~First, we have to wait to merge the
[PR-29](celestiaorg/.github#29), because we need
the file available in the right path.~~

---

## Checklist

- [x] Merge [PR-29](celestiaorg/.github#29).
- [x] Need to be tested before merging this one.
- [x] Linked issues closed with keywords

---

(cherry picked from commit 7380eec)
evan-forbes pushed a commit that referenced this pull request May 26, 2023
## Overview

Helloo team!

This PR uses the common CI pipeline for building the Docker containers
and tagging them.

馃毃 ~~First, we have to wait to merge the
[PR-29](celestiaorg/.github#29), because we need
the file available in the right path.~~

---

## Checklist

- [x] Merge [PR-29](celestiaorg/.github#29).
- [x] Need to be tested before merging this one.
- [x] Linked issues closed with keywords

---

(cherry picked from commit 7380eec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants