Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register testnode cleanup in teardown #1372

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 10, 2023

Overview

Closes #1358

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the testing items that are strictly related to adding or extending test coverage label Feb 10, 2023
@rach-id rach-id self-assigned this Feb 10, 2023
@MSevey MSevey requested review from a team and rootulp and removed request for a team February 10, 2023 18:59
@codecov-commenter
Copy link

Codecov Report

Merging #1372 (75cb43d) into main (f4eb8c1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   48.34%   48.34%           
=======================================
  Files          79       79           
  Lines        4422     4422           
=======================================
  Hits         2138     2138           
  Misses       2105     2105           
  Partials      179      179           
Impacted Files Coverage Δ
testutil/testnode/full_node.go 61.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rach-id rach-id changed the title feat: register cleanup in teardown feat: register testnode cleanup in teardown Feb 10, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cleaner

@rach-id rach-id merged commit ff69444 into celestiaorg:main Feb 10, 2023
@rach-id rach-id deleted the cleanup_in_teardown branch February 10, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNode stick everything in the testing.T.Cleanup
3 participants