test: add QGB queries test #1374
Conversation
rach-id
added
x/qgb
testing
Co-authored-by: Rootul P <rootulp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1374 +/- ##
=======================================
Coverage 48.35% 48.35%
=======================================
Files 79 79
Lines 4438 4438
=======================================
Hits 2146 2146
Misses 2113 2113
Partials 179 179 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| _, cctx := testnode.DefaultNetwork(t, time.Millisecond) | ||
| h, err := cctx.WaitForHeightWithTimeout(401, time.Minute) |
There was a problem hiding this comment.
[definitely optional]
if we don't want to wait a minute here, we can change the genesis state to include a significantly shorter data window param
There was a problem hiding this comment.
We won't wait a minute. It's just a worst case scenario. Generally, with a block time of 1ms, 401 blocks will be created in less than half a second.
Yes, we can do that, but ,with fast blocktime, i dont see why tinker with the genesis state and do more changes.
Im okey with any tbh, whichever you prefer 🐱
There was a problem hiding this comment.
its fine as is, just an optimization 👍
Overview
Closes #1343
Checklist