refactor: Keep only the common Ci #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmanes
requested review from
evan-forbes,
Bidon15,
rootulp,
smuu,
rach-id and
sysrex
jrmanes
added
CI
rach-id
approved these changes
Feb 15, 2023
Good point! I used the following in another project. - name: Set env
run: echo "IMAGE_NAME=$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV |
|
I like that solution 👍 |
Bidon15
approved these changes
Feb 15, 2023
evan-forbes
approved these changes
Feb 16, 2023
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
May 25, 2023
## Overview Hello team! In order to keep only the pipeline that we've created for common uses, I've removed the previous one, and this one will be the only one. I've changed the name to: ``` docker-build-publish-common.yml -> docker-build-publish.yml ``` *It has been already tested.* Thanks in advance! ## Checklist - [x] Required CI checks are passing - [x] Linked issues closed with keywords Closes 50%: celestiaorg/devops#61 (cherry picked from commit d759b54)
evan-forbes
pushed a commit
that referenced
this pull request
May 26, 2023
## Overview Hello team! In order to keep only the pipeline that we've created for common uses, I've removed the previous one, and this one will be the only one. I've changed the name to: ``` docker-build-publish-common.yml -> docker-build-publish.yml ``` *It has been already tested.* Thanks in advance! ## Checklist - [x] Required CI checks are passing - [x] Linked issues closed with keywords Closes 50%: celestiaorg/devops#61 (cherry picked from commit d759b54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hello team!
In order to keep only the pipeline that we've created for common uses, I've removed the previous one, and this one will be the only one.
I've changed the name to:
It has been already tested.
Thanks in advance!
Checklist
Closes 50%: celestiaorg/devops#61