Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: explicitly set namespace size #1385

Merged
merged 1 commit into from
Feb 15, 2023
Merged

chore: explicitly set namespace size #1385

merged 1 commit into from
Feb 15, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 15, 2023

Closes #1384

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Feb 15, 2023
@rootulp rootulp self-assigned this Feb 15, 2023
@MSevey MSevey requested review from a team and rahulghangas and removed request for a team February 15, 2023 18:44
evan-forbes
evan-forbes approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope!

@rootulp rootulp merged commit dea47f8 into celestiaorg:main Feb 15, 2023
@rootulp rootulp deleted the rp/explicit-namespace-size branch February 15, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rahulghangas rahulghangas Awaiting requested review from rahulghangas rahulghangas is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using nmt.DefaultNamespaceIDLen
2 participants
@rootulp @evan-forbes