feat: data commitment for height support for yet to be committed heights #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Feb 16, 2023
| return types.DataCommitment{}, err | ||
| } | ||
| if !found { | ||
| return types.DataCommitment{}, fmt.Errorf("couldn't find attestation with nonce %d", latestNonce-i) |
There was a problem hiding this comment.
[non-blocking]
do we have an specific error type for this? it feels general enough to warrant one
There was a problem hiding this comment.
This we're creating errors on the fly throughout the whole package, I created an issue to handle the all #1390
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
evan-forbes
previously approved these changes
Feb 16, 2023
evan-forbes
approved these changes
Feb 16, 2023
rootulp
reviewed
Feb 16, 2023
| // GetLastDataCommitment returns the last data commitment. | ||
| func (k Keeper) GetLastDataCommitment(ctx sdk.Context) (types.DataCommitment, error) { | ||
| latestNonce := k.GetLatestAttestationNonce(ctx) | ||
| for i := uint64(0); i < latestNonce; i++ { |
There was a problem hiding this comment.
[no change needed] sorry for delayed review but this iteration may read easier with
for i := latestNonce; i >= 0; i-- {because the contents of this for loop care about iterating from the latest nonce down to 0. This proposal removes the need for subtraction in the body of the for loop
rootulp
added a commit
that referenced
this pull request
Feb 16, 2023
Addresses this delayed feedback: #1389 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1388
Checklist