Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unused build tags from go test #1397

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 16, 2023

Closes #1396

@rootulp rootulp self-assigned this Feb 16, 2023
@MSevey MSevey requested review from a team and rach-id and removed request for a team February 16, 2023 20:50
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these were added when the project was initially generated. I would defer to Evan to confirm if they're needed

@rootulp
Copy link
Collaborator Author

rootulp commented Feb 16, 2023

I'm pretty confident they're not needed b/c I couldn't find any instances of the build tags in test files so specifying the tags in go test doesn't change which tests are run. I confirmed they were initially added in c3b312e

@evan-forbes
Copy link
Member

yeah, they're not needed

@rootulp rootulp merged commit 8ee0d07 into celestiaorg:main Feb 17, 2023
@rootulp rootulp deleted the rp/remove-build-tags branch February 17, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused build tags
3 participants