Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use DefaultNetwork instead of duplicate code #1410

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 22, 2023

Overview

Remove duplicated code and use directly DefaultNetwork.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the testing items that are strictly related to adding or extending test coverage label Feb 22, 2023
@rach-id rach-id self-assigned this Feb 22, 2023
@MSevey MSevey requested review from a team and mojtaba-esk and removed request for a team February 22, 2023 12:27
@rach-id
Copy link
Member Author

rach-id commented Feb 22, 2023

2 checks are failing:

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all integration tests still pass. Nice clean up 🧹

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while a lot of the code is duplicated, the reason for leaving this after we introduced DefaultNetwork was to illustrate what needed to be done to have a test with a custom genesis state.

however we do need to test DefaultNetwork, and we can always reverse engineer DefaultNetwork, so 👍

@evan-forbes
Copy link
Member

we can also show how to do a custom genesis state when we #829

@rach-id rach-id merged commit 37614da into celestiaorg:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants