chore: create a WaitForBlocks util helper function #1430
Conversation
MSevey
requested review from
a team and
staheri14
and removed request for
a team
phamminh0811
changed the title
There was a problem hiding this comment.
Thanks for the contribution @ phamminh0811 ! This looks good to me after a small nit with respect to the function name and Godoc.
Do you mind renaming the PR title from chores: to chore: to conform to https://www.conventionalcommits.org/en/v1.0.0/#specification
Updtate: nvm I can rename the PR title
rootulp
changed the title
There was a problem hiding this comment.
same as other reviewers feedback
in a future PR, it would also be cool if we added this for testnode as well, which is the integration test implementation that we will use long term
thanks @phamminh0811 !
Co-authored-by: Rootul P <rootulp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
=======================================
Coverage 49.22% 49.22%
=======================================
Files 79 79
Lines 4477 4477
=======================================
Hits 2204 2204
Misses 2089 2089
Partials 184 184 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Overview
closes #1238, create a WaitForBlocks util helper function