Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores: QGB keepers specific errors #1431

Merged
merged 3 commits into from
Mar 3, 2023
Merged

chores: QGB keepers specific errors #1431

merged 3 commits into from
Mar 3, 2023

Conversation

phamminh0811
Copy link
Contributor

Overview

closes #1390, this pr add some specific errors on QGB keepers data commitment and make sure previous tests success

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from a team February 28, 2023 07:25
rach-id
rach-id requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for handling this 👍 👍 🚀

Left some blocking comments, ping me to re-review when they're addressed

testutil/testnode/full_node.go Outdated Show resolved Hide resolved
testutil/testnode/full_node.go Outdated Show resolved Hide resolved
testutil/testnode/rpc_client.go Outdated Show resolved Hide resolved
testutil/testnode/rpc_client.go Outdated Show resolved Hide resolved
x/qgb/types/errors.go Outdated Show resolved Hide resolved
x/qgb/types/errors.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper_data_commitment.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper_data_commitment.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper_data_commitment.go Outdated Show resolved Hide resolved
x/qgb/keeper/keeper_data_commitment.go Outdated Show resolved Hide resolved
@rach-id rach-id added the x/qgb label Feb 28, 2023
@MSevey MSevey requested a review from a team February 28, 2023 10:21
@phamminh0811
Copy link
Contributor Author

Thanks a lot for handling this +1 +1 rocket

Left some blocking comments, ping me to re-review when they're addressed

it's all resolved, please check

rach-id
rach-id approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

evan-forbes
evan-forbes approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @phamminh0811

@evan-forbes evan-forbes merged commit 62eae87 into celestiaorg:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@phamminh0811 phamminh0811

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QGB keepers specific errors
3 participants
@phamminh0811 @rach-id @evan-forbes