refactor(testutil/testnode): Allow passing chainID to testnode constuctor #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
the
warn:api breaking
evan-forbes
approved these changes
Mar 7, 2023
evan-forbes
reviewed
Mar 7, 2023
| tmNode, app, cctx, err := New(t, DefaultParams(), tmCfg, false, genState, kr) | ||
| tmNode, app, cctx, err := New(t, DefaultParams(), tmCfg, false, genState, kr, tmrand.Str(6)) |
There was a problem hiding this comment.
we could optionally also bubble this up if you all want to hopefully avoid duplicate code in https://github.com/celestiaorg/celestia-node/blob/main/core/testing.go, but I understand just using the current apis
There was a problem hiding this comment.
Up to you - I'm fine with whatever. We use testnode constructor directly
MSevey
approved these changes
Mar 7, 2023
rootulp
approved these changes
Mar 7, 2023
This was referenced Mar 7, 2023
rootulp
pushed a commit
to rootulp/celestia-app
that referenced
this pull request
Mar 31, 2023
…ctor (celestiaorg#1445) Allows customising the `chainID` of the testnode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows customising the
chainIDof the testnode.