Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cosmossdk.io/errors #1448

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 7, 2023

Closes #1446

Before: make lint showed warnings
After: make lint shows no more warnings

$ make lint
--> Running golangci-lint
--> Running markdownlint

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 7, 2023
@rootulp rootulp self-assigned this Mar 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1448 (cf60b1a) into main (4ee939b) will decrease coverage by 0.03%.
The diff coverage is 14.81%.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   49.21%   49.19%   -0.03%     
==========================================
  Files          79       79              
  Lines        4480     4478       -2     
==========================================
- Hits         2205     2203       -2     
  Misses       2091     2091              
  Partials      184      184              
Impacted Files Coverage Δ
app/verify_txs.go 0.00% <0.00%> (ø)
x/blob/handler.go 0.00% <0.00%> (ø)
x/qgb/abci.go 51.02% <ø> (ø)
x/qgb/handler.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_valset.go 27.11% <0.00%> (ø)
x/qgb/types/validator.go 39.79% <0.00%> (ø)
x/qgb/types/valset.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_data_commitment.go 52.45% <25.00%> (ø)
x/qgb/types/genesis.go 70.96% <100.00%> (ø)
x/tokenfilter/ibc_middleware.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp marked this pull request as ready for review March 7, 2023 19:07
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for switching!

@rootulp rootulp merged commit e5e37ec into celestiaorg:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make lint shows deprecated usage of sdkerrors
4 participants