Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to log directly to a file #1449

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Conversation

evan-forbes
Copy link
Member

Overview

This PR simply adds the option via a new flag to log directly to a file. This feature was requested by @Bidon15 to not have to use the &> in the cli. If this turns out to be a desirable feature, we can easily expand on this in the future.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the enhancement New feature or request label Mar 7, 2023
@evan-forbes evan-forbes self-assigned this Mar 7, 2023
@MSevey MSevey requested review from a team and staheri14 and removed request for a team March 7, 2023 20:44
@MSevey MSevey requested a review from a team March 7, 2023 20:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #1449 (4fec5a6) into main (4ee939b) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 4fec5a6 differs from pull request most recent head eba8e02. Consider uploading reports for the commit eba8e02 to get more accurate results

@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
- Coverage   49.21%   49.19%   -0.03%     
==========================================
  Files          79       79              
  Lines        4480     4478       -2     
==========================================
- Hits         2205     2203       -2     
  Misses       2091     2091              
  Partials      184      184              
Impacted Files Coverage Δ
testutil/testnode/full_node.go 82.87% <0.00%> (-0.24%) ⬇️
x/qgb/handler.go 0.00% <0.00%> (ø)
app/verify_txs.go 0.00% <0.00%> (ø)
x/blob/handler.go 0.00% <0.00%> (ø)
x/qgb/types/genesis.go 70.96% <0.00%> (ø)
x/qgb/keeper/keeper_valset.go 27.11% <0.00%> (ø)
x/tokenfilter/ibc_middleware.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants