Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue label and project automation #1456

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 8, 2023

Closes #1455

The issue label automation was inspired by celestiaorg/celestia-node#1877
The project automation uses add-to-project

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Mar 8, 2023
@rootulp rootulp self-assigned this Mar 8, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 8, 2023

I don't see either of the automation CI checks running on this PR so I don't have confidence that they work as expected. It could be they only run after this merges but I'm suspicious

@rootulp rootulp marked this pull request as ready for review March 8, 2023 20:45
@rootulp rootulp requested a review from MSevey March 8, 2023 20:45
@MSevey
Copy link
Member

MSevey commented Mar 8, 2023

I don't see either of the automation CI checks running on this PR so I don't have confidence that they work as expected. It could be they only run after this merges but I'm suspicious

Yea I haven't fully figured out when actions PRs run vs needing to be merged in first.

Also a second reason why it might not have run is because we are intentionally using the open trigger. So PR updates aren't going to trigger it. iirc the reason for that is for labels we don't want the action to re-add labels we removed for example. Plus there is no reason it needs to run more than once.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK and makes sense afaiu

I don't see either of the automation CI checks running on this PR so I don't have confidence that they work as expected. It could be they only run after this merges but I'm suspicious

same, unfortunately there's only one way to test this lol and we can adjust with future PRs. we can also try on other repos (not forks, since github treats forks very differently)

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 8, 2023

I'm going to test in prod 😆

@rootulp rootulp merged commit 0c7806a into celestiaorg:main Mar 8, 2023
@rootulp rootulp deleted the rp/auto-triage branch March 8, 2023 21:16
@rootulp rootulp mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto specify project when creating new issues in celestia-app/core
3 participants