Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Images Security #1473

Merged
merged 13 commits into from
Mar 16, 2023
Merged

Conversation

smuu
Copy link
Member

@smuu smuu commented Mar 13, 2023

This is part of: celestiaorg/test-infra#160.

  • Use a non-root user named celestia (UID/GID = 10001)
  • Dependabot now also scans Dockerfiles in the docker folder
  • Change to folder /home/celestia

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu requested a review from evan-forbes as a code owner March 13, 2023 10:47
@MSevey MSevey requested review from a team and rach-id and removed request for a team March 13, 2023 10:48
evan-forbes
evan-forbes previously approved these changes Mar 13, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile_ephemeral Show resolved Hide resolved
rach-id
rach-id previously approved these changes Mar 13, 2023
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu dismissed stale reviews from rach-id and evan-forbes via 6b0aff6 March 13, 2023 14:42
@MSevey MSevey requested a review from a team March 13, 2023 14:49
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Merging #1473 (204387f) into main (953860c) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
+ Coverage   50.93%   50.97%   +0.04%     
==========================================
  Files          81       81              
  Lines        4661     4665       +4     
==========================================
+ Hits         2374     2378       +4     
  Misses       2103     2103              
  Partials      184      184              
Impacted Files Coverage Δ
app/app.go 3.98% <75.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should close the loop on unit testing the new function and adding the link to the go docs about the default value for the user home directory

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@MSevey MSevey requested a review from a team March 15, 2023 09:38
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu requested review from MSevey and jrmanes March 15, 2023 16:07
@smuu smuu requested a review from evan-forbes March 16, 2023 08:03
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
evan-forbes
evan-forbes previously approved these changes Mar 16, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice improvements, thanks for this 🙂

@evan-forbes evan-forbes enabled auto-merge (squash) March 16, 2023 10:32
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
auto-merge was automatically disabled March 16, 2023 13:27

Head branch was pushed to by a user without write access

@MSevey MSevey requested a review from a team March 16, 2023 13:27
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@MSevey
Copy link
Member

MSevey commented Mar 16, 2023

@evan-forbes Does this resolve #377 now? Or is that a slightly different issue?

Since we are now loading the env var.

@evan-forbes
Copy link
Member

yeah, we should be able to close #377

@evan-forbes evan-forbes merged commit d48d927 into celestiaorg:main Mar 16, 2023
@smuu smuu deleted the feature/container-security branch March 17, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants